Thanks for pointing out that typo for page 107. Unfortunately it’s too late now to get it into the reprint but I’ll add to my list.

As for the whole toggling of the "odd" variable, yes, I did do it for pedagogical, rather than coding reasons.

You’re right: the changes you suggest would be more elegant, but then I would also have to explain exactly what was going on. By simply writing code that’s close to the English, "if odd is equal to true…", the flow of the logic is fairly clear without any extra explanation.

There’s quite a few places in the book where the code could be shortened and improved considerably, but I generally chose readability and clarity at the expense of code elegance.

Also, I’m sure many programmers would balk at my constant flaunting of structured programming best practices. Again, it was readability I was striving for.

Now, about that beer…

p107 there’s a line

if (whichpic.getAttribue("title"))

which should clearly say "getAttribute".

p196, nothing incorrect but you’ve done something that makes me shout at my year 1 programming undergrads:

if (odd == true)

should just be

if (odd)

This may be a pedagogical decision on your part I suppose but I strongly object to using == to check boolean data.

Also I’d prefer the two lines

odd = false; and odd = true;

to come outside the if-statement and coexist as

odd = !odd;

which makes it clear that you’re toggling.

Very nice book, clear explanations etc. I want to buy you a beer in Brighton sometime.

Guy.

Enjoying the book very much.